Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change error code to TRANSPORT_PARAMETER_ERROR #207

Merged
merged 1 commit into from
Jul 10, 2023
Merged

change error code to TRANSPORT_PARAMETER_ERROR #207

merged 1 commit into from
Jul 10, 2023

Conversation

mirjak
Copy link
Contributor

@mirjak mirjak commented Jul 7, 2023

fixes #179

@mirjak mirjak mentioned this pull request Jul 7, 2023
Closed
@marten-seemann
Copy link
Contributor

Actually, PROTOCOL_VIOLATION is correct here. TRANSPORT_PARAMETER_ERROR should only be used if the error can be detected by a (stateless) frame parser.

@mirjak
Copy link
Contributor Author

mirjak commented Jul 9, 2023

Why "frame" parser? This is about transport parameter...?

@mirjak
Copy link
Contributor Author

mirjak commented Jul 10, 2023

Also note that this check is stateless as it only depends on another transport parameter, namely min_ack_delay, which should be present in the same packet.

@mirjak mirjak merged commit 0f5dfc9 into main Jul 10, 2023
3 checks passed
@ianswett
Copy link
Collaborator

This seems like the correct change to me, but @marten-seemann do you think this is correctly resolved, or should this issue be re-opened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error code for invalid Request Max Ack Delay values
3 participants
@mirjak @marten-seemann @ianswett